This repository was archived by the owner on Sep 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
well this is alarming, @dwijnand does this alarm you?
|
9bb4098
to
46cc381
Compare
trying again now without the sbt version bump |
That happens to me occasionally. |
Tracked in sbt/sbt#2863. |
new PR with just the sbt bump: #84 |
som-snytt
reviewed
Apr 11, 2017
@@ -8,16 +8,7 @@ | |||
package scala.tools.partest | |||
package nest | |||
|
|||
import java.io.{ | |||
File, | |||
IOException, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed opportunity for trailing mccomma.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't count your trailing comma chickens before the 2.12.2 egg has hatched!
47 tasks
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
fix unused warnings
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
fix unused warnings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there isn't a 2.12.2 nightly quite yet with scala/scala#5402 in it,
but I tested with ++2.12.2-bin-bad61ce-SNAPSHOT
the sbt version bump is unrelated(removed)